Repository navigation
Conversation
Preserve main's communicator split, pooled-indexer padding fix, and platform cleanup while retaining the BCG eager-method refactor.
Oasis-Git
requested review from
1am9trash,
Alisehen,
AniZpZ,
BBuf,
Edwardf0t1,
FlamingoPg,
Fridge003,
HaiShaw,
OrangeRedeng,
Qiaolin-Yu,
YAMY1234,
Ying1123,
adarshxs,
b8zhong,
ch-wan,
fzyzcjy,
hebiao064,
hnyls2002,
hubertlu-tw,
ispobock,
kkHuang-amd,
merrymercy,
mmangkad,
ping1jing2,
rainj-me and
whybeyoung
as code owners
September 29, 2026 05:27
Collaborator
|
@CaoE take a look at this one. sglang is changing from PCG to BCG |
This was referenced Oct 2, 2026
arathi-hlab
added a commit
to arathi-hlab/sglang
that referenced
this pull request
Oct 5, 2026
XPU CI (stage-a-test-1-gpu-xpu) fails on every PR in test/registered/xpu/test_xpu_graph.py: the tc_piecewise prefill graph compiles the Qwen2 decoder with fullgraph=True, and since sgl-project#42301 the forward builds msgspec.Struct layer-boundary values that Dynamo (torch 2.13) cannot construct inside a compiled region. tc_piecewise is being removed in sgl-project#41634, so rather than reworking the layer-boundary classes for a graph mode that is going away, skip the test case for now and refactor the XPU graph test once sgl-project#41634 lands.
arathi-hlab
added a commit
to arathi-hlab/sglang
that referenced
this pull request
Oct 5, 2026
XPU CI (stage-a-test-1-gpu-xpu) fails on every PR in test/registered/xpu/test_xpu_graph.py: the tc_piecewise prefill graph compiles the Qwen2 decoder with fullgraph=True, and since sgl-project#42301 the forward builds msgspec.Struct layer-boundary values that Dynamo (torch 2.13) cannot construct inside a compiled region. tc_piecewise is being removed in sgl-project#41634, so rather than reworking the layer-boundary classes for a graph mode that is going away, mark the test disabled in its CI registration (run_suite.py then skips the file) and refactor the XPU graph test once sgl-project#41634 lands.
mingfeima
pushed a commit
that referenced
this pull request
Oct 5, 2026
3 of 5 tasks
2 tasks done
nvpohanh
added a commit
to nvpohanh/sglang
that referenced
this pull request
Oct 5, 2026
The file is also registered in the per-commit AMD suite stage-b-test-1-gpu-large-amd, where it fails with the same object.__new__(Contribution) error since the Qwen2 decoder was built from stage boundaries, and its failure cancels the sibling partitions. Both of its tests exist only to exercise tc_piecewise, which is being removed (sgl-project#41634), so there is nothing to keep or move. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thanhhao98
pushed a commit
to thanhhao98/sglang
that referenced
this pull request
Oct 5, 2026
tc_piecewise is being removed (sgl-project#41634) and M3 now defaults to breakable, so restore these files to main.
This was referenced Oct 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ❌ Run #36651021053
Latest PR Test (Extra): ❌ Run #36651020873
Latest PR Test (AMD ROCm 10): ❌ Run #36651021020